Fixes #26243: Improve license errors handling in webapp #6138
+1,154
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
2 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
clarktsiory
force-pushed
the
ust_26243/improve_license_errors_handling_in_webapp
branch
3 times, most recently
from
bb4e1be to
920b0a1
Compare
clarktsiory
force-pushed
the
ust_26243/improve_license_errors_handling_in_webapp
branch
from
920b0a1 to
fae2807
Compare
clarktsiory
force-pushed
the
ust_26243/improve_license_errors_handling_in_webapp
branch
from
fae2807 to
da94e6c
Compare
Fixes #26243: Improve license errors handling in webapp
|
PR updated with a new commit |
Fixes #26243: Improve license errors handling in webapp
|
PR updated with a new commit |
… webapp Fixes #26243: Improve license errors handling in webapp
|
PR updated with a new commit |
…ling in webapp Fixes #26243: Improve license errors handling in webapp
|
PR updated with a new commit |
clarktsiory
commented
Feb 3, 2025
| /** | ||
| * Display the attributes of this result, by default each on a new line with indentation | ||
| */ | ||
| def debugString(sep: String = "\n "): String = s"code: ${code}\n stderr: ${stderr}\n stdout: ${stdout}" |
There was a problem hiding this comment.
I will apply this in places where it should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/26243
Several improvements, both in the displayed error information and the logic of error display while the list of plugin is showed :
errorDetailsmessage was not read correctly, we should never read Bytes in Elm